Add Windows hypervisor primitives - #428
Conversation
c9e657a to
4ab69ee
Compare
-->
✱ stlc build✅ go code · compare
✅ python code · compare
✅ typescript code · compare
Diagnostics: ❗ 0 new / 1 total error, 💡 0 new / 5 total note
Build metadata
This comment is auto-generated by stlc and is kept up to date as you push. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 32eb71a. Configure here.
1 participant
summary
targeted tests
go test ./lib/hypervisor/qemu ./lib/hypervisor ./lib/paths ./lib/instances ./cmd/api/api -run ... -count=1Long-running KVM and full CI suites were not run for this review pass.
Note
Medium Risk
Touches VM boot, firmware, and TPM process lifecycle on QEMU, including CI KVM integration. Existing Linux direct-boot paths stay default but mis-validation could reject or mis-start guests.
Overview
Adds hypervisor-level UEFI boot, qcow2 disks, and software TPM 2.0 so standard QEMU (q35) can run Windows-style firmware guests without hard-coding backend names.
VMConfignow carriesBootMode, firmware (immutable code + per-instance NVRAM), TPM socket/state, and disk format. Empty values keep today’s direct-kernel + raw-disk behavior. QEMU startsswtpmfirst, then QEMU, on one cleanup stack; fork path rewriting covers firmware and TPM files. Other backends (cloud-hypervisor,firecracker,vz,qemu-microvm) reject UEFI/TPM/qcow2.Exposes
source=swtpmon instance logs and installs OVMF/swtpmin CI for a dedicated Windows-config integration test.Reviewed by Cursor Bugbot for commit 6b63aca. Bugbot is set up for automated code reviews on this repo. Configure here.